Skip to content

fix: exclude passbackconversiontrackingid from selectPlacements attribute persistence #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmi22186 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: exclude passbackconversiontrackingid from selectPlacements attribute persistence #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/selectPlacementsAttributePersistence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const SELECT_PLACEMENTS_ATTRIBUTE_PERSISTENCE_DENY_LIST = [
'couponcode',
'currency',
'language',
'passbackconversiontrackingid',
'paymentserviceprovider',
'paymentserviceproviderattribute',
'paymenttype',
Expand Down
2 changes: 2 additions & 0 deletions test/src/tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5809,6 +5809,8 @@ describe('Rokt Forwarder', () => {
expect(isSelectPlacementsAttributePersistenceDenied('paymentServiceProvider')).toBe(true);
expect(isSelectPlacementsAttributePersistenceDenied('cartItems')).toBe(true);
expect(isSelectPlacementsAttributePersistenceDenied('conversionType')).toBe(true);
expect(isSelectPlacementsAttributePersistenceDenied('passbackconversiontrackingid')).toBe(true);
expect(isSelectPlacementsAttributePersistenceDenied('passbackConversionTrackingId')).toBe(true);
});

it('should return false for attributes that are not denylisted', () => {
Expand Down