Repository navigation
#70 Handle group process termination - #71
Conversation
mtkennerly
left a comment
There was a problem hiding this comment.
Thanks for this! Just had a few small comments :)
|
I updated the implementation to use Windows’ built-in Job Object with KILL_ON_JOB_CLOSE, so child processes are terminated automatically without needing to iterate over all running processes. Also, just a heads-up: VirusTotal (specifically the SecureAge engine) is flagging the .exe as malicious. That engine tends to give a lot of false positives, but I’m seeing the same flag even on the master build with --release. |
mtkennerly
left a comment
There was a problem hiding this comment.
This is great 🎉 Thanks for the feature. I'll make a new release within the next day or two to get this out.
Nah, I don't do any signing. Maybe this is one of those situations where it builds trust after enough people have used a particular version? When I scanned the updated build here, it complained about |
This PR solves the issue in #70