Skip to content

#70 Handle group process termination - #71

Merged
mtkennerly merged 3 commits into
mtkennerly:masterfrom
nitaysol:feature/kill-group-process
Dec 8, 2025
Merged

mtkennerly merged 3 commits into
mtkennerly:masterfrom
nitaysol:feature/kill-group-process

Conversation

@nitaysol

@nitaysol nitaysol commented Dec 3, 2025 •

Copy link
Copy Markdown
Contributor

This PR solves the issue in #70

@nitaysol nitaysol changed the title Stuff Auto PR - handle group process termination Dec 4, 2025
@nitaysol nitaysol changed the title Auto PR - handle group process termination Handle group process termination Dec 4, 2025
@nitaysol nitaysol changed the title Handle group process termination #70 Handle group process termination Dec 4, 2025

@mtkennerly mtkennerly left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just had a few small comments :)

Comment thread src/service.rs Outdated
Comment thread src/service.rs Outdated
Comment thread src/service.rs Outdated
@nitaysol
nitaysol requested a review from mtkennerly December 6, 2025 14:23
@nitaysol

nitaysol commented Dec 6, 2025 •

Copy link
Copy Markdown
Contributor Author

I updated the implementation to use Windows’ built-in Job Object with KILL_ON_JOB_CLOSE, so child processes are terminated automatically without needing to iterate over all running processes.
I added tests to confirm the behavior, but I still want to run a few local tests on my machine :)
If you see anything in the code that should be adjusted, I’m open to suggestions.

Also, just a heads-up: VirusTotal (specifically the SecureAge engine) is flagging the .exe as malicious. That engine tends to give a lot of false positives, but I’m seeing the same flag even on the master build with --release.
Interestingly, the downloadable release binary is not flagged, so it might be something introduced recently - or maybe you’re signing the release binaries?

Link: https://www.virustotal.com/gui/file/920186ed1000f46f6d14b43e51c123a13869e37239d2727460bfb0d077cd58d4?nocache=1

@nitaysol
nitaysol marked this pull request as ready for review December 6, 2025 16:22
@mtkennerly mtkennerly added this to the v1.8.0 milestone Dec 8, 2025
@mtkennerly mtkennerly added the enhancement New feature or request label Dec 8, 2025

@mtkennerly mtkennerly left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🎉 Thanks for the feature. I'll make a new release within the next day or two to get this out.

@mtkennerly

Copy link
Copy Markdown
Owner

Interestingly, the downloadable release binary is not flagged, so it might be something introduced recently - or maybe you’re signing the release binaries?

Nah, I don't do any signing. Maybe this is one of those situations where it builds trust after enough people have used a particular version? When I scanned the updated build here, it complained about Trojan:Script/Wacatac.B!ml, which I've definitely seen in some false positives before. It's only one complaint out of all the scans they run, so oh well 🙃

@mtkennerly
mtkennerly merged commit 6342a78 into mtkennerly:master Dec 8, 2025
3 of 4 checks passed
mtkennerly added a commit that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants