Fix summon menu overwriting active spell target - #40
Open
nightNR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• ## Description
Fixes an issue where opening the summon target selection menu overwrote the character’s active action context while another spell was still waiting for its
cast delay.
For targeted summons, m_Act_UID and m_Act_Prv_UID are now left unchanged until the summon target is selected. Non-targeted summons retain the existing behavior
of setting both values to the casting character.
This prevents the summon menu from corrupting the target information of an active spell.
———
Type of Change
———
Related Issues
None.
———
Testing
———
Checklist
———
Additional Notes
The PR consists of one commit and changes only src/game/clients/CClient.cpp.
Local uncommitted changes present in the working tree are not part of this PR.