Skip to content

Fix summon menu overwriting active spell target - #40

Open
nightNR wants to merge 1 commit into
mtwango:dark-paradisefrom
nightNR:fix/summon-targetting
Open

Fix summon menu overwriting active spell target#40
nightNR wants to merge 1 commit into
mtwango:dark-paradisefrom
nightNR:fix/summon-targetting

Conversation

@nightNR

@nightNR nightNR commented Aug 19, 2026

Copy link
Copy Markdown

• ## Description

Fixes an issue where opening the summon target selection menu overwrote the character’s active action context while another spell was still waiting for its
cast delay.

For targeted summons, m_Act_UID and m_Act_Prv_UID are now left unchanged until the summon target is selected. Non-targeted summons retain the existing behavior
of setting both values to the casting character.

This prevents the summon menu from corrupting the target information of an active spell.

———

Type of Change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation update
  • Build / CI change
  • Other (please describe)

———

Related Issues

None.

———

Testing

  • Tested on a clean SphereServer instance with latest ScriptPack
  • No regressions in existing functionality
  • Added or updated tests (if applicable)

———

Checklist

  • Code compiles successfully
  • Changes follow the project's coding style
  • No unrelated code was modified
  • Documentation updated where necessary (not applicable)
  • This PR does not introduce breaking changes

———

Additional Notes

The PR consists of one commit and changes only src/game/clients/CClient.cpp.

Local uncommitted changes present in the working tree are not part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant