Fix mounted and shrunken NPC position sync - #41
Open
nightNR wants to merge 1 commit into
Open
Conversation
Author
|
Tento fix je postaveny len na teoretickych zisteniach a v lokalnom prostredi neviem nasimulovat povodny problem.. Zrejme ma suvis s velkostou save, mnozstvom aktivnych zon atd. ALe mal by riesit stav, kedy hracom zmiznu jazditka alebo sa z aktivuju zonove triggery f.e. v zonach kde zabija jazditka po zosadnuti (f.e. Ankh 3 koniec) pocas WorldSave(alebo garbageCollect).. chcelo by to skusit s realnym save pripadne PTR .. podobne ako fix Death() processu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes position synchronization issues affecting mounted and shrunken NPCs during world saves and garbage collection.
The hidden NPC representation of an equipped mount could remain at a stale position after its rider moved. During garbage collection, the server attempted to
correct this through the normal movement pipeline. This could execute region, location, and environmental triggers for the hidden NPC, potentially killing or
releasing the mount and automatically dismounting its rider.
The changes:
———
Type of Change
———
Related Issues
None.
———
Testing
Manual testing confirmed the previous behavior where the hidden mount NPC remained at a stale position after its rider moved. Sector sleeping, activation,
garbage collection, and background world-save scenarios were also exercised.
———
Checklist
———
Additional Notes
The fix intentionally bypasses normal region, room, environmental, and location triggers when synchronizing disconnected mounted or shrunken NPCs. This
relocation is internal bookkeeping and should not behave as normal gameplay movement.
The changelog has been updated to document the corrected world-save, garbage-collection, and mount-position behavior.