chore: add job to notify on new release - #674
Open
kangmingtay wants to merge 2 commits into
Open
kangmingtay wants to merge 2 commits into
kangmingtay wants to merge 2 commits into
Conversation
Signed-off-by: Kang Ming <kang.ming1996@gmail.com>
kangmingtay
force-pushed
the
km/notify-builder-on-current
branch
from
September 22, 2026 23:45
7eadb09 to
f5ead6c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Verolop
reviewed
Sep 23, 2026
Verolop
reviewed
Sep 23, 2026
Verolop
left a comment
Verolop
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
Before merging: moving the image copying into the private builder makes sense. I’d prefer to keep private-repo credentials there too and use polling, with a way to catch missed versions.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
Verolop
reviewed
Sep 26, 2026
| dist/install*.yaml | ||
|
|
||
| notify-builder: | ||
| needs: update-current-release |
Contributor
There was a problem hiding this comment.
The release is published before the copy finishes. Dispatch can succeed even if the copy or digest check later fails, leaving a green upstream workflow and a release that isn’t ready in ECR. Someone updating the deployment pin could hit an image pull error or deploy an image that failed verification.
See our nightly build and compatibility workflow before reporting success or proposing new image pins. Can we also require the ECR copy and digest check to pass for that SHA before updating the deployment pin? 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.