test(e2e): drop replicasPerCell from 4 to 3 - #676
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
soedirgo
force-pushed
the
bobbie/shard-yaml-mem
branch
from
September 24, 2026 21:55
ce63ec6 to
79282c0
Compare
Contributor
Author
|
/e2e |
soedirgo
changed the title
This comment has been minimized.
This comment has been minimized.
|
✅ E2E tests success — View run |
soedirgo
marked this pull request as ready for review
September 24, 2026 22:15
The E2E framework overwrites pool resources with 32Mi memory, which corresponds to 5 max_replication_slots. With replicasPerCell=4, that's 4 x 2 (cells) - 1 (primary) = 7 standbys, so there's not enough replication slots to go by. Drop to 3 replicasPerCell, which corresponds to 5 standbys - just enough slots for the test Signed-off-by: Bobbie Soedirgo <bobbie@soedirgo.dev>
Verolop
force-pushed
the
bobbie/shard-yaml-mem
branch
from
September 25, 2026 06:02
79282c0 to
be8b5be
Compare
Verolop
approved these changes
Sep 25, 2026
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E framework overwrites pool resources with 32Mi memory, which corresponds to 5 max_replication_slots. With replicasPerCell=4, that's 4 x 2 (cells) - 1 (primary) = 7 standbys, so there's not enough replication slots to go by.
Drop to 3 replicasPerCell, which corresponds to 5 standbys - just enough slots for the test
Fixes E2E (templated) failures.