Conversation
Build the observer image for linux/amd64 on pull requests and pushes to main using the repository root context. Cache build layers without publishing an image or logging into a registry. Validation: actionlint passes; the current Dockerfile builds successfully; removing COPY pkg/ reproduces the missing pkg/topology build failure. Fixes multigres#687 Signed-off-by: makinje <malcolm.akinje@gmail.com>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an observer Docker build check on pull requests and pushes to
main, skipping documentation-only changes.This catches missing Docker build inputs that Go tests against the full checkout cannot detect.
The check builds
tools/observer/Dockerfilewith the repository root as context forlinux/amd64only. It cachesbuild layers, cancels superseded runs, and requires no registry credentials or image publishing.
Fixes #687.
Validation
actionlintpasses.COPY pkg/from a temporary Dockerfile causes the build to fail on the missingpkg/topologyimport,confirming coverage of the regression fixed by fix(observer): copy root packages into image builder #682.