refactor: pair callables with signatures - #607
Draft
baszalmstra wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bas/place-projections #607 +/- ##
=========================================================
+ Coverage 86.58% 87.46% +0.87%
=========================================================
Files 254 254
Lines 26887 26946 +59
=========================================================
+ Hits 23281 23567 +286
+ Misses 3606 3379 -227 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
baszalmstra
marked this pull request as draft
September 6, 2026 13:54
baszalmstra
force-pushed
the
bas/typed-callables
branch
from
September 6, 2026 14:10
ef89101 to
ab4dc86
Compare
baszalmstra
force-pushed
the
bas/typed-callables
branch
from
September 6, 2026 14:27
ab4dc86 to
719d1ee
Compare
baszalmstra
force-pushed
the
bas/typed-callables
branch
from
September 6, 2026 15:29
719d1ee to
55f1c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Indirect calls relied on LLVM function-pointer element types to recover the call signature. Opaque pointers erase that type, so a loaded address is not enough to emit a valid call.
What
Callablenewtype that owns a function pointer and itsFunctionTypeTesting
pixi run checkwithRUSTFLAGS=-Dwarningspixi run cargo test -p mun_codegen --libpixi run cargo test -p mun_codegen --test abi