Added a duration type fix - #166
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves support for custom types derived from
time.Durationthat implement their ownMarshalJSONmethod. Previously, such types were incorrectly rendered as integers in generated JSON schemas rather than as duration strings. The changes ensure these types are correctly identified and their schema is set to"string"with format"duration". Several regression tests are added to verify this behavior.Custom duration type handling:
isDurationLikeTypefunction to detect named types derived fromtime.Durationthat implementjson.Marshaler, ensuring they are treated as duration strings in schemas.applySpecialTypeSchemaandmarshalDefaultto useisDurationLikeType, so custom duration types are rendered with type"string"and format"duration". [1] [2]Testing improvements:
customDurationtype andcustomDurationStructfor testing, simulating a common pattern where packages define local duration types with custom JSON marshaling.TestFor_CustomDuration_TopLevelandTestFor_CustomDuration_StructField) to verify that custom duration types are properly handled in both top-level and struct field contexts.