Conversation
Adds an argument translator for CF commands using the previous definitions. All commands which had the definition modified as part of nasa#516 are changed to point at a compatibility shim instead of invoking the command directly. New (temporary) command codes are added to invoke the "non-shim" command directly. This should all be considered deprecated from the start and removed in a future update. This is purely to preserve compatibility with existing scripts.
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
254 is the old compound-key sentinel for transaction commands, but CF_Translate_CompatChannel() maps it to all channels and that helper is also used by Freeze, Thaw, TxFile, EnableDequeue, etc. So an invalid channel 254 on those commands becomes a valid all-channels command. The 254 special case should stay in the transaction translator; the generic channel translator should only special-case 255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: FSW Code Change
about: Flight Software code changes
labels: fsw
Description of Change
Adds an argument translator for CF commands using the previous definitions.
All commands which had the definition modified as part of #516 are changed to point at a compatibility shim instead of invoking the command directly. New (temporary) command codes are added to invoke the "non-shim" command directly.
This should all be considered deprecated from the start and removed in a future update. This is purely to preserve compatibility with existing scripts.
Linked Issue
Closes #521
Requirements Impact
Testing Evidence
Unit Tests (UT Assert)
COSMOS Test Suite
Areas of Expertise Touched
Author Checklist
.clang-formatReviewer Checklist
.clang-formathas been appliedReviewer Testing Notes