Fix nasa#144, removed assignments that are never used as detected by static code analysis

[myc-yang]

For members of the cFS Team
Click the Preview tab and select the pull request template corresponding to the type of change you are submitting:

• Comment/Documentation Change
• Flight Software Code Change
• Workflows Change

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution
Fixes #144

Testing performed
Static code analysis and Unit Tests

Expected behavior changes
No impact to behavior

System(s) tested on

• Hardware: PC
• OS: Linux

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang / NASA/GSFC

[jphickey]

Coding standards say we should declare variables at the top of the function, not midway at the time of use.

Just keep all declarations at the beginning with no assignment, and assign later.

[jphickey]

Just remove the assignment to CFE_SUCCESS and keep the declaration here.

[myc-yang]

So do you want a one line for a declaration and then a separate line for the assignment?

i.e.
CFE_Status_t Result;

Result = CS_AppInit();