Part #120, reject unmatched derived command dispatch - #121
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part #120.
Description
Distinguish non-derived message types from failed derivative identification. Query the type metadata first, retain position-zero dispatch only for types without derivatives, and reject failed identification before any handler is invoked. Preserve matching-derivative routing and message-size validation, and propagate an unreadable message size instead of using it.
This proposes
CFE_STATUS_VALIDATION_FAILUREfor unmatched derived commands. Please confirm the intended dispatch/error semantics before merging; #120 remains open as a clarification issue.Testing performed
Debian 12 arm64, GCC 12.2, EDS-enabled native cFE/OSAL build:
edsmsglibrary and the newedsmsg-dispatcher-testtarget.git diff --checkpassed.The committed test target runs within an EDS-enabled cFE build. Full standalone EdsLib validation, COSMOS, mission/network integration, and hardware testing were not run. The generated-data check was a supplementary local validation, not an additional committed target.
Expected behavior changes
No public signature changes. Unmatched derived commands are rejected instead of invoking the first handler. Genuinely non-derived commands retain handler zero. Invalid database metadata returns
CFE_SB_INTERNAL_ERR.Contributor info
Sylvester Kaczmarek, Personal. No third-party code added. Contributor License Agreement submission status is unverified.