Fix #114: remove redundant initial state check in LC_SampleAPs

[philphauler]

Summary

Remove the redundant guard on the starting AP state in LC_SampleAPs.

Problem

LC_SampleAPs(StartIndex, EndIndex) checks ARTPtr[StartIndex].CurrentState
before entering the sampling loop. If the first AP is PERMOFF or NOT_USED,
the entire range is skipped and an error event is emitted -- even though
subsequent APs in the range may be operational.

LC_SampleSingleAP already checks each AP state individually, making this
pre-check redundant and harmful when a range begins with a disabled AP.

Fix

Remove the pre-check. Let LC_SampleSingleAP handle per-AP state filtering
for each action point in the range. Net deletion of 21 lines.

[philphauler]

Removes a redundant initial-state check that LC_SampleSingleAP already handles per-AP. 6 lines added, 27 removed. No behavioral change — the per-AP handler covers all cases.

[dzbaker]

@philphauler Thank you for your contribution. Please resolve the workflow failures.

[philphauler]

Already onnit 🫡🙏

[philphauler]

Tracked the coverage failure down 🔍 the two LC_SampleAPs error-state tests (lc_action_tests.c:81 and the PermOff one) still expected the LC_APSAMPLE_CURR_ERR_EID event this PR removes on purpose, since LC_SampleSingleAP already skips non-ACTIVE/PASSIVE actionpoints quietly. Updated both tests to assert no event is sent, merged the latest dev in with a merge commit, and pushed 51a1d61.

Locally (cFS dev bundle, native_eds): 100% tests passed, 0 tests failed out of 7, and lc_action.c sits at 100% lines / 100% branches under gcov.

The Build Documentation failure is unrelated to this PR: it is the doxygen \SB_DELPIPEEC warning from cfe/modules/sb/config/default_cfe_sb_msgdefs.h, which is still present on current dev. Left that alone 🚀