Skip to content

Fix #179, use canonical Stored Command event definitions - #180

Open
sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-179-canonical-event-header
Open

sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-179-canonical-event-header

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Fixes #179.

Replace the stale Data Store event catalog in sc_eventids.h with a compatibility include of the canonical sc_events.h. Keep the old include path, remove conflicting/copied definitions, and correct the HS reference and file description in the canonical header.

The active SC event numbers are unchanged. Five names in the stale header had conflicting numeric values; the remaining copied Data Store identifiers were unused by SC and are removed. The original license notice is preserved.

Validation

Debian 12 arm64, GCC 12.2, native cFE/OSAL, EDS disabled:

  • All eight SC coverage targets passed: 329 cases and 1,313 assertions, repeated 10 times.
  • Existing application and command test files now include both headers in opposite orders. This failed with macro redefinitions before the fix and builds with warnings treated as errors afterward.
  • Standalone C99 header check with Clang and -Wall -Wextra -Werror passed.
  • The flight application and sc-usersguide documentation build passed.
  • Clang-format 19 on changed lines and git diff --check passed.

Full mission/COSMOS, EDS-enabled and hardware testing were not run.

Contributor: Sylvester Kaczmarek, Personal. No third-party code added. Contributor License Agreement submission status is unverified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SC Headers Reference Other Apps (DS and HS)

2 participants