Fix #179, use canonical Stored Command event definitions - #180
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179.
Replace the stale Data Store event catalog in
sc_eventids.hwith a compatibility include of the canonicalsc_events.h. Keep the old include path, remove conflicting/copied definitions, and correct the HS reference and file description in the canonical header.The active SC event numbers are unchanged. Five names in the stale header had conflicting numeric values; the remaining copied Data Store identifiers were unused by SC and are removed. The original license notice is preserved.
Validation
Debian 12 arm64, GCC 12.2, native cFE/OSAL, EDS disabled:
-Wall -Wextra -Werrorpassed.sc-usersguidedocumentation build passed.git diff --checkpassed.Full mission/COSMOS, EDS-enabled and hardware testing were not run.
Contributor: Sylvester Kaczmarek, Personal. No third-party code added. Contributor License Agreement submission status is unverified.