Fix #2446, clarify startup token count message - #2792
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
August 13, 2026 13:12
sylvesterkaczmarek
force-pushed
the
fix-2446-startup-token-count-message
branch
from
September 10, 2026 14:50
1d11205 to
9b80353
Compare
Author
|
Rebased onto current dev and resolved the conflict by moving the change into the new startup-parser source, preserving the upstream refactor. Config, ES, TBL and Task Affinity coverage targets pass for ten repetitions locally; formatting and diff checks pass. New CI results are pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #2446.
Clarify the malformed startup-script diagnostic so the reported value is explicitly identified as
NumTokensand the required minimum is stated.The parser rejects entries with fewer than eight tokens. The previous message printed only the raw count, which could be mistaken for a startup-file entry or line number.
Testing performed
NumTokens = 0, expected at least 8.Expected behavior changes
System(s) tested on
dev.Additional context
The branch is one commit ahead of
dev, zero commits behind, and changes only the ES diagnostic plus its regression assertion.Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Sylvester Kaczmarek, Personal
Latest rebase validation
Rebased onto current
devat39d765fa568943c50c6a8f7dbc957edc31607900. Preserved the upstream startup-parser refactor and moved the relevant change tocfe_es_startupscript.c. Config, ES, TBL, and TA coverage targets all passed for ten repetitions in a Debian 12 arm64 native configuration with EDS disabled. The local TA fixture supplies its required performance ID. Clang-format 19 andgit diff --checkpassed. New upstream CI results are pending.