fix(es): use PLATFORM bound for pool bucket array size check

[philphauler]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide
• I signed and emailed the CLA

Describe the contribution

Fixes #2828. In CFE_ES_PoolCreateEx_WithAlignment(), NumBlockSizes is checked against CFE_MISSION_ES_POOL_MAX_BUCKETS, but the Buckets[] array is sized to CFE_PLATFORM_ES_POOL_MAX_BUCKETS. When MISSION > PLATFORM (valid per cfe_missionlib_verify.h), the bounds check passes but subsequent writes exceed the array, causing OOB writes.

One-line fix: replace CFE_MISSION_ES_POOL_MAX_BUCKETS with CFE_PLATFORM_ES_POOL_MAX_BUCKETS in cfe_es_mempool.c so the check matches the actual array size.

Testing performed

The bucket-count check in cfe_es_mempool.c now uses the PLATFORM bound the array is allocated with, and the syslog prints that same bound. Run locally in the cFS dev bundle: coverage-es passes. With sample_defs (MISSION == PLATFORM == 17) behavior is unchanged; the check only differs when a mission raises the MISSION bound above the PLATFORM allocation.

Expected behavior changes

Configurations where CFE_MISSION_ES_POOL_MAX_BUCKETS > CFE_PLATFORM_ES_POOL_MAX_BUCKETS now correctly reject excess bucket counts instead of writing out of bounds.

System(s) tested on

Hardware: x86_64 (WSL2), OS: Ubuntu 22.04, Versions: cFE dev 2612eb0 with OSAL and PSP from the cFS dev bundle, native build with ENABLE_UNIT_TESTS

Contributor Info

Filip Koscak - phil.phaulre@gmail.com

[philphauler]

Hi @dzbaker 👋 thanks for the nudge. Commit message now matches the check (b3c8f82), and the syslog prints the same PLATFORM bound the check uses. coverage-es passes. Have a nice day!

Going to assign review to cFS Core dev team.

[philphauler]

Nice! Sorry for taking the time, I'll also sign the CLA thingy asap, and run some more online courses to become actually more useful 🙏🙌

[philphauler]

Quick update: my Individual CLA for the cFS framework went to GSFC-SoftwareRelease on 2026-09-16, after this PR was opened, so I've ticked that box in the checklist. Happy to adjust anything if needed.