feat: auto-populate season/disc from title + editable fields on job details#32
Open
negativeeddy wants to merge 2 commits into
Open
feat: auto-populate season/disc from title + editable fields on job details#32negativeeddy wants to merge 2 commits into
negativeeddy wants to merge 2 commits into
Conversation
added 2 commits
July 26, 2026 14:24
…etails Implements PR4 of mkv-auto research recommendations: 1. Auto-populate season/disc: TitleNormalizer runs during IdentifyService to extract season and disc numbers from the disc title or label. Results stored on Job as SeasonNumberAuto/DiscNumberAuto and used as defaults for SeasonNumber/DiscNumber. 2. New Job fields: SeasonNumberManual, DiscNumberManual, DiscNumberAuto, StartingEpisodeNumber — all persisted to DB. StartingEpisodeNumber is passed through to DiscContext for provider offset. 3. Editable Identification card: Season, Disc, and Starting Episode fields added to the job details page with Auto/Manual/Final columns. Manual overrides set the final value; clearing them reverts to auto. 4. ArmRipperService uses job.DiscNumber (with ParseDiscNumber fallback) and job.StartingEpisodeNumber when building DiscContext, so the values the user sets on the UI flow through to episode identification. Build: 0 errors, 0 warnings. Tests: 102/102 ArmMedia pass (pre-existing failures in Core/WebUi tests unrelated).
The new Job columns (SeasonNumberAuto, SeasonNumberManual, DiscNumber, DiscNumberAuto, DiscNumberManual, StartingEpisodeNumber) were added to the EF Core model but not to the DatabaseHelper.EnsureMigrated schema patches, causing 'no such column' errors on existing databases. Added TryAlterColumn calls for all 6 new columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR4 of the mkv-auto research recommendations. Auto-populates season/disc numbers from disc title normalization and adds editable fields to the job details page so users can review and correct them before episode identification runs.
Changes
Auto-populate season/disc —
TitleNormalizerruns duringIdentifyService.IdentifyAsyncfor series/TV jobs. Extracts season and disc numbers from the disc title or label (e.g. "Season 3 Disc 2" → season=3, disc=2). Results stored asSeasonNumberAuto/DiscNumberAutoand used as defaults.New Job fields —
SeasonNumberManual,DiscNumberManual,DiscNumberAuto,StartingEpisodeNumberpersisted to DB.StartingEpisodeNumberflows through toDiscContextso providers use the correct episode offset.Editable Identification card — Season, Disc, and Starting Episode rows added to the job details page with Auto/Manual/Final columns, matching the existing Title/Year/VideoType pattern.
Provider context uses job values —
ArmRipperServicereadsjob.DiscNumberandjob.StartingEpisodeNumberwhen buildingDiscContext, so user edits flow through to all identification providers.Before vs After
SeasonNumberalways null → defaults to 1DiscNumberparsed ad-hoc from labelTest Results
Depends on
PR#31 (TMDB Season Catalog) — already merged.