Repository navigation
Rework the tray card into the upstream card anatomy - #813
Merged
Merged
Conversation
- Card = header, metric rows, key-value sections, inline dashboard, credits / extra usage (upstream UsageMenuCardView). Plan is plain footnote text; errors use --mac-error; --provider-accent is always set. - Account menus become a "Switch Account..." row that opens Settings. - Pace budgets + chart, session forecast, burndown, DeepSeek pricing, pace bars and quota window history move to Settings > Providers. - Switcher and Overview spend summary restyled (spec 3.1, 3.2). - Tray dark-tint overrides replaced by a per-surface --surface-tint-rgb. - New tray-card.css, scoped to .menu-surface--tray and loaded last.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Card-rework PR 3 of the Mac-parity tray panel: the provider card now has the upstream
UsageMenuCardViewanatomy.What users see in the tray panel:
Removed from the card, and where it went
Decisions implemented
zoom: trayScale; new Rust tests pin the Panel scale bounds tosrc/lib/trayScale.ts.--provider-accentis now always set from the existing brand color.#0078d4.--surface-tint-rgb(white on dark surfaces, black on the light tray) replaces the tray-only dark-tint overrides.Two behaviour fixes found in the visual loop
MenuDescriptor.hasAccount.Commands and results
All run in
W:/wcb-wt/mac-card-anatomywithCARGO_TARGET_DIR=W:\cargo-target\mac-card-anatomyandCARGO_BUILD_JOBS=3.cargo fmt --allcargo test --manifest-path rust/Cargo.tomlcargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warningscargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.tomltrayScalebound tests)cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warningspnpm test(apps/desktop-tauri)3550c9ec9)pnpm run build(apps/desktop-tauri)The cargo gates ran before the last two commits (
1952741a5,3550c9ec9); those touch only frontend TypeScript and tests.pnpm testandpnpm run buildwere rerun in full at3550c9ec9.Proof (webview capture through CDP, win_run.py)
Before (Mac 0.70.0 | Windows main):
W:/mac-parity/report/card-sheets/<Pack>.pngAfter (Mac 0.70.0 | this branch):
W:/mac-parity/report/mac-card-anatomy/final/<Pack>.pngRaw panels:
W:/mac-parity/win-runs/<Pack>@mac-card-anatomy/panel.pngPacks: Claude, Codex, OpenRouter, Copilot, Cursor, Vercel. Proof build of
3550c9ec9(W:/mac-parity/win-bin-mac-card-anatomy).W:/mac-parity/report/card-sheets/Claude.pngW:/mac-parity/report/mac-card-anatomy/final/Claude.pngW:/mac-parity/report/card-sheets/Codex.pngW:/mac-parity/report/mac-card-anatomy/final/Codex.pngW:/mac-parity/report/card-sheets/OpenRouter.pngW:/mac-parity/report/mac-card-anatomy/final/OpenRouter.pngW:/mac-parity/report/card-sheets/Copilot.pngW:/mac-parity/report/mac-card-anatomy/final/Copilot.pngW:/mac-parity/report/card-sheets/Cursor.pngW:/mac-parity/report/mac-card-anatomy/final/Cursor.pngW:/mac-parity/report/card-sheets/Vercel.pngW:/mac-parity/report/mac-card-anatomy/final/Vercel.pngWhere the extras went (Settings > Providers,
--mode settings:providers, dark under themeauto):W:/mac-parity/win-runs/ClaudeSettings@mac-card-anatomy/panel.png(Usage details with per-window on-pace budgets, pace bars, Charts)W:/mac-parity/win-runs/CodexSettings@mac-card-anatomy/panel.png(Usage details and Charts)Manual CUA check for the coordinator (real tray, theme
auto)win_run.py captures the webview only. Please check on the real tray with a fresh build of this branch:
#0078d4with white icon; hover is instant (no fade).auto.autoafter opening the tray and Settings.Gaps against the Mac shots (not in this PR)
"balance": "125.50"withas_f64and gets 0 (rust/src/providers/codex/api.rs). Provider scope, not this PR.build_codex_quota_history(rust/src/providers/chart.rs, unchanged here) reads the cost-scan cache, and a chart snapshot built before the scan writes that cache has no window entries; the FE-loop run had one extra usage refresh that would rebuild it. The old card hid this behind the collapsed disclosure, so this PR makes a pre-existing cold-start state visible on the card face. Worth its own issue.accountEmailnull. Claude has no Extra usage block (no cost in the data), and Today reads "—" because the fixture logs end before today.Conflicts
This PR rewrites
MenuCard.tsx, removesMenuCardDetails.tsxand the account menu components, and addstray-card.css. It will conflict with the open "simplify" PRs #794, #795, #796, #798, #800, #801, #802, #803 and #804. Whichever lands second needs a rebase; the simplify changes to the removed files can be dropped.