Repository navigation
build: drop containers and build with host Node.js - #202
Merged
Merged
Conversation
Use import.meta.dirname instead of __dirname, which Vite 8 warns about when loading the config, and rename build.rollupOptions to build.rolldownOptions, deprecated since Vite 8. The built dist output is unchanged. Assisted-by: Claude Code:Opus 5.5
Use import.meta.dirname instead of __dirname, which Vite 8 warns about when loading the config. The playground build output is unchanged. Assisted-by: Claude Code:Opus 5.5
Develop with the host Node.js version pinned in .nvmrc instead of the dev container, and document the nvm setup in CONTRIBUTING.md. Remove the now unused dev stage from the Containerfile. The container builds used by CI and releases are unchanged. Recommend the VS Code extensions needed by the project through .vscode/extensions.json. Assisted-by: Claude Code:Opus 5.5
Build the library and the Storybook directly on the CI runner, with the Node.js version from .nvmrc, as in local development. Without the container, Tailwind's automatic source detection would also scan the stories and the playground: limit it to src/ for the library, and add the stories explicitly to the Storybook CSS. Assisted-by: Claude Code:Opus 5.5
stephdl
reviewed
Oct 8, 2026
stephdl
left a comment
stephdl
left a comment
There was a problem hiding this comment.
Pin all runners to ubuntu-24.04.
is there any reason, why not ubuntu-26.04
Replace ubuntu-latest and ubuntu-24.04 with ubuntu-26.04, generally available on GitHub Actions since September 2026, in all workflows. Runner upgrades then come as Renovate PRs tested by the CI, instead of happening when GitHub moves ubuntu-latest. Assisted-by: Claude Code:Opus 5.5
andre8244
force-pushed
the
build/vite-config-deprecations
branch
from
October 8, 2026 16:07
57d2ee5 to
104b361
Compare
Collaborator
Author
You're right! I'll amend the commit |
Tbaile
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.nvmrc; removeContainerfile,build.sh,dev.shand the devcontainer.src/for the library build, and add stories explicitly to the Storybook CSS, so no extra classes leak intodist..vscode/extensions.json.import.meta.dirname,build.rolldownOptions).ubuntu-26.04.Verified that
dist/main.css, the ESM bundle and the type declarations are byte-identical to the container build. The UMD bundle no longer includes four unused rules (.rotate-*,.shrink) that the vite 8 container build leaked. Tested inmywith type-check, build and unit tests.