-
Notifications
You must be signed in to change notification settings - Fork 48
fix(context): keep formatted and linked text in section titles #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
human0-bot
merged 1 commit into
neuledge:main
from
JayOfTheKeyboard:fix/heading-formatted-text
Oct 3, 2026
+82
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@neuledge/context": patch | ||
| --- | ||
|
|
||
| Keep bold, italic, link and inline-code text in section titles. Only a heading's top-level text was read, so words inside formatting or links were dropped from the title, which has the highest search weight. In the Python docs, 300 of 6,475 sections lost words (`Numeric Types — int, float, complex` became `Numeric Types — , , `), including 152 FAQ and guide sections whose heading is a link and which were titled "Introduction". Markdown was hit too: `## Using [superjson](...)` became "Using ". Heading permalinks such as Sphinx's "¶" stay out of the title. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,23 @@ for (const tag of REMOVED_TAGS) { | |
| turndown.remove(tag); | ||
| } | ||
|
|
||
| // Permalink anchors in section headings: "¶" (Sphinx, systemd), "§" (rustdoc), "#" | ||
| // (VuePress) or a zero-width space (Docusaurus). Section titles keep link text, so | ||
| // without this they end in the symbol. Only <h2>, which becomes the section title: | ||
| // anchors in other headings stay in the content as before. A rule, not remove(): | ||
| // the link rule would match <a> first. | ||
| const PERMALINK_TEXT = /^[¶§#🔗]?$/u; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docs & rules · comment: The permalink predicate also accepts This codebase is managed by Human0. |
||
| turndown.addRule("sectionPermalink", { | ||
| filter: (node) => | ||
| node.nodeName === "A" && | ||
| (node.getAttribute("href") ?? "").startsWith("#") && | ||
| PERMALINK_TEXT.test( | ||
| (node.textContent ?? "").replace(/\u200b/g, "").trim(), | ||
| ) && | ||
| node.closest("h2") !== null, | ||
| replacement: () => "", | ||
| }); | ||
|
|
||
| // DocBook emits bare <pre> elements; Turndown's code rule requires <pre><code>. | ||
| // Preserve their whitespace and prevent Markdown escaping of unit-file examples. | ||
| turndown.addRule("barePre", { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs & rules · question: Can you add the source or a short reproduction procedure for the corpus counts and before/after comparisons in this changeset? They are not reproducible from the tracked scripts, fixtures, or artifacts.
This codebase is managed by Human0.