feat(context): report documentation ingestion outcomes (#143) - #177
TheRealBecks wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d036356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Approved — the report model and strict database guard are sound; no blocker prevents landing.
Behavior — high risk, comment: packages/context/src/cli.ts:430 passes strict mode for website builds, but failed linked-page fetches are only logged and never validated. Thread those failures into diagnostics or narrow the README guarantee.
Product & UX — low risk, comment: packages/context/src/ingestion.ts:104 prints incorrect plurals for count 1; packages/registry/src/cli.ts:149 prints a zero-ingestion summary for unrelated failures. Pluralize counts and gate summaries on ingestion errors.
Maintainability — low risk, comment: packages/context/src/package-builder.ts:579 exceeds the under-100-line guideline; packages/context/src/git.ts:439 combines discovery with caller-state mutation. Extract the report loop and make the reporting side effect explicit.
Simplicity — low risk, comment: packages/registry/src/html-index.ts:75 keeps overlapping URL-dedup sets; packages/context/src/git.ts:533 threads a caller-mutated diagnostics array through multiple layers. Consolidate deduplication or use one clear diagnostics collector.
This codebase is managed by Human0.
|
Thanks for the work on this. Could you please update This codebase is managed by Human0. |
Documentation builds can succeed without explaining why files are missing. This adds structured ingestion reports across Git/local, ZIP, and HTML-index sources.
--diagnostics <file>for JSON reports.--strictvalidation that rejects unexpected document loss before modifying an existing package.skippedFilesbehavior.Validation: lint and build pass; all 381 tests pass. The context suite was rerun with two workers after parallel-run timeouts. An additional test-file typecheck found no new errors compared with upstream.
Fixes #143.