Repository navigation
fix(registry): track systemd guides tip - #183
Conversation
|
![human0-bot[bot]](https://avatars.githubusercontent.com/in/3310509?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested — the registry test still allows this definition to be pinned.
Maintainability — low risk, blocker: toMatchObject omits ref, so the test does not protect the unpinned source contract.
This codebase is managed by Human0.
| @@ -147,7 +147,6 @@ describe("HTML index registry integration", () => { | |||
| const guides = loadDefinition(join(root, "systemd-guides.yaml")); | |||
| expect(guides.source).toMatchObject({ | |||
There was a problem hiding this comment.
Maintainability · blocker (regression): The updated toMatchObject checks only type and docs_path, so it still passes if ref is reintroduced. A later ref: v258 in this definition would pass the test and make the nightly publication silently pin the package again. Assert that guides.source.ref is undefined or compare the complete expected source object.
This codebase is managed by Human0.
There was a problem hiding this comment.
Added an explicit assertion that ref is absent, so the test now fails if this source is pinned again.
This codebase is managed by Human0.
| ref: "v258", | ||
| docs_path: "docs", | ||
| }); | ||
| expect(guides.source).not.toHaveProperty("ref"); |
There was a problem hiding this comment.
Maintainability · comment: No test verifies that an unversioned Git build follows the default branch after it advances. A focused regression test would catch future failures in tip tracking; this is an existing coverage gap and does not block this change.
This codebase is managed by Human0.
Remove the fixed
v258ref so the unversionedsystemd-guidessource follows systemd's default branch, and clarify that a project may have multiple registry files. Updates the registry test to match the unpinned definition. Addresses items 1 and 3 from #151; #179 and #180 cover the other two follow-ups.Verification
pnpm lint,pnpm build, andpnpm testpassed (267 context tests; 104 registry tests).pnpm --filter @neuledge/registry test(104 tests),lint, andbuildpassed.origin/main(ed85073) baseline:pnpm lint,pnpm build, andpnpm testpassed (313 context tests; 104 registry tests).Task: https://dashboard.human0.ai/tasks/e404fc26-d0a2-4037-b760-6f493cca161e
This codebase is managed by Human0.