Skip to content

Enhance authentication flow with GitHub and Cloudflare support - #169

Merged
AnkanSaha merged 5 commits into
mainfrom
maintainer/ankan
Sep 4, 2026
Merged

AnkanSaha merged 5 commits into
mainfrom
maintainer/ankan

Conversation

@AnkanSaha

Copy link
Copy Markdown
Member

This pull request updates the authentication flow to support both Google and GitHub as sign-in providers, consolidates the sign-in and sign-up panels into a single component, and improves user feedback for authentication events. It also updates various pages and tests to reflect these changes and improves error handling and UI consistency.

Authentication provider enhancements:

  • The GoogleAuthPanel component now supports both Google and GitHub sign-in, with appropriate UI and busy state handling for each provider. The sign-in and sign-up flows are unified into a single panel with updated copy. (client/src/components/auth/GoogleAuthPanel.tsx [1] [2] [3] [4] [5]
  • Added a GithubMark icon for GitHub authentication to AuthLayout. (client/src/components/auth/AuthLayout.tsx client/src/components/auth/AuthLayout.tsxR129-R134)

Testing updates:

  • Tests for GoogleAuthPanel are updated and expanded to cover GitHub sign-in, busy state handling, and unified sign-in logic. Mocks for GitHub provider are added. (client/src/__tests__/components/auth/GoogleAuthPanel.test.tsx [1] [2] [3]; client/src/__tests__/components/auth/PasskeyLogin.test.tsx [4] [5]; client/src/__tests__/contexts/AuthContext.test.tsx [6] [7]
  • Added a test to ensure an error is shown if the sign-in popup is closed without completing. (client/src/__tests__/contexts/AuthContext.test.tsx client/src/tests/contexts/AuthContext.test.tsxR98-R129)

Page and navigation changes:

Error and notification handling:

  • Added toast notifications for Cloudflare OAuth connection and error states on the onboarding and load balancer pages. (client/src/app/onboarding/page.tsx [1] [2]; client/src/app/loadbalancers/page.tsx [3]

These changes streamline authentication, improve the user experience, and ensure tests cover the new logic.

@AnkanSaha AnkanSaha self-assigned this Sep 4, 2026
@AnkanSaha
AnkanSaha merged commit c7ea690 into main Sep 4, 2026
6 checks passed
@AnkanSaha
AnkanSaha deleted the maintainer/ankan branch September 4, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant