Repository navigation
Enhance authentication flow with GitHub and Cloudflare support - #169
Merged
Merged
Conversation
… account linking constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication flow to support both Google and GitHub as sign-in providers, consolidates the sign-in and sign-up panels into a single component, and improves user feedback for authentication events. It also updates various pages and tests to reflect these changes and improves error handling and UI consistency.
Authentication provider enhancements:
GoogleAuthPanelcomponent now supports both Google and GitHub sign-in, with appropriate UI and busy state handling for each provider. The sign-in and sign-up flows are unified into a single panel with updated copy. (client/src/components/auth/GoogleAuthPanel.tsx[1] [2] [3] [4] [5]GithubMarkicon for GitHub authentication toAuthLayout. (client/src/components/auth/AuthLayout.tsxclient/src/components/auth/AuthLayout.tsxR129-R134)Testing updates:
GoogleAuthPanelare updated and expanded to cover GitHub sign-in, busy state handling, and unified sign-in logic. Mocks for GitHub provider are added. (client/src/__tests__/components/auth/GoogleAuthPanel.test.tsx[1] [2] [3];client/src/__tests__/components/auth/PasskeyLogin.test.tsx[4] [5];client/src/__tests__/contexts/AuthContext.test.tsx[6] [7]client/src/__tests__/contexts/AuthContext.test.tsxclient/src/tests/contexts/AuthContext.test.tsxR98-R129)Page and navigation changes:
/registerpage now redirects to/login, and the/loginpage uses the unifiedGoogleAuthPanel. (client/src/app/register/page.tsx[1]client/src/app/login/page.tsx[2]/logininstead of/register. (client/src/app/blog/[slug]/page.tsxclient/src/app/blog/[slug]/page.tsxL128-R128,client/src/app/testimonials/page.tsxclient/src/app/testimonials/page.tsxL34-R34)Error and notification handling:
client/src/app/onboarding/page.tsx[1] [2];client/src/app/loadbalancers/page.tsx[3]These changes streamline authentication, improve the user experience, and ensure tests cover the new logic.