Repository navigation
Add Inspect button for application definitions - #539
Merged
Merged
Conversation
Lint Base Class now passes the class name so that base classes in the contributed definitions can be found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Validation Panel can now show the NXDL file of an application definition, and linting a base class works for base classes in the contributed definitions.
Summary
inspect_application()from nexusformat. It is enabled whenever Lint is.base_classes, so contributed base classes (e.g.NXgoniometer) are found and linted.Requires the next nexusformat release after 2.1.0, which adds
inspect_application()and the lint changes (nexpy/nexusformat#276).