Repository navigation
Do not treat Ellipsis or None as a floating point slice - #278
Open
aaronkanzer wants to merge 1 commit into
Open
aaronkanzer wants to merge 1 commit into
aaronkanzer wants to merge 1 commit into
Conversation
NXfield indices such as field[..., -1] or field[None, 0] on a multidimensional field raised 'NXfield must be one-dimensional for floating point slices', because is_real_slice converted Ellipsis and None to object arrays, which are not integer dtypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexing a multidimensional NXfield with
...orNone(np.newaxis) raises an error, whether the field is in memory or loaded from a file.Observed:
NeXusError: NXfield must be one-dimensional for floating point slices.x[0, ...],x[None, 0]andx[:, None]fail the same way.Expected:
[4 9 14 19], the same as NumPy.Cause:
is_real_slicechecks each index element withnp.array(x).dtype.np.array(Ellipsis)andnp.array(None)are object arrays, so they count as real values, andconvert_indexthen rejects the 2D field.Fix: return False for
EllipsisandNonein the inneris_realcheck. A parametrized test covers...andnp.newaxison 2D and 3D fields.