Skip to content

🕵️ Add sharereview support#8052

Draft
AndyScherzinger wants to merge 11 commits into
feat/noid/share-metadatafrom
feat/noid/sharereview
Draft

🕵️ Add sharereview support#8052
AndyScherzinger wants to merge 11 commits into
feat/noid/share-metadatafrom
feat/noid/sharereview

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Target version: main

Summary

Enabled the share review app to retrieve general share information and enabled the app to delete shares.

TODO

  • run CI
  • clarify share meta data

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch 3 times, most recently from 935be19 to 6f0363f Compare June 11, 2026 16:18
AndyScherzinger
AndyScherzinger commented Jun 11, 2026
View reviewed changes
Comment thread lib/ShareReview/ShareReviewSource.php Outdated
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96709 was 93102 (+3.87%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96680 was 93102 (+3.84%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch 2 times, most recently from 957ce8d to 069046e Compare June 16, 2026 10:01
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96661 was 93102 (+3.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch 2 times, most recently from b442ed4 to 21b2f12 Compare June 19, 2026 18:33
@AndyScherzinger AndyScherzinger changed the base branch from main to feat/noid/share-metadata June 19, 2026 18:59
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/share-metadata branch from fe4ab81 to e7ede00 Compare June 19, 2026 19:00
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch from 21b2f12 to d7e4ccd Compare June 19, 2026 19:01
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/share-metadata branch 2 times, most recently from af1f803 to 7e3e603 Compare June 19, 2026 19:31
@AndyScherzinger AndyScherzinger mentioned this pull request Jun 19, 2026
Open
6 tasks
@AndyScherzinger
feat(sharereview): add listener registering Deck as a share source
ff12607 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): add ShareReviewSource with constructor and getName()
ca82100 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): implement getShares() with board name lookup via JOIN
33f3fc2 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): implement deleteShare() via direct SQL with logging
6d601fa 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): register ShareReview listener on SourceEvent
32f9d96 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(sharereview): apply coding standards and Psalm fixes
cfcdc45 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
test(sharereview): add unit tests for ShareReviewSource
70a6961 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(sharereview): harden and optimize implementation and testing
20dacc8 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Use the new share meta-data instead of a hard-coded date
28a991f 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch from d7e4ccd to 28a991f Compare June 19, 2026 19:49
@AndyScherzinger
feat(sharereview): gate ACL deletion behind event-based access check
dbdce8e 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
refactor(sharereview): address pre-review feedback on ShareReviewSource
e4cb923 
- Remove 'app' key from getShares() return values; the ShareReview
  consumer already injects the app name from getName()
- Add TABLE_NAME constants to AclMapper and BoardMapper so table names
  have a canonical owner and don't leak into unrelated classes
- Move the ACL+board JOIN query to AclMapper::findAllForShareReview()
  and drop the IDBConnection dependency from ShareReviewSource
- Introduce ShareReviewShare DTO; getShares() now builds typed objects
  via buildShare() and converts them with toArray()
- Log a warning for unknown ACL participant types instead of silently
  defaulting to TYPE_USER
- Localize user-facing strings in resolveObjectName() via IL10N

Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud will be requested when the pull request is marked ready for review luka-nextcloud is a code owner

@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt will be requested when the pull request is marked ready for review grnd-alt is a code owner

Assignees

No one assigned

Labels

2. developing AI assisted enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger