fix: cast boardUsers to string#8066
Conversation
Signed-off-by: grnd-alt <git@belakkaf.net>
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable33 |
| $card = $this->cardMapper->find($cardId); | ||
| $boardId = $this->cardMapper->findBoardId($cardId); | ||
| $boardUsers = array_keys($this->permissionService->findUsers($boardId, true)); | ||
| $boardUsers = array_map(fn (string|int $userId) => (string)$userId, array_keys($this->permissionService->findUsers($boardId, true))); |
There was a problem hiding this comment.
php converts array keys, that are inserted as strings, to int if possible, so the later in_array fails if the user_id passed is a string but boardUsers contains ints for numeric userIds
|
🐢 Performance warning. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/8066/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f562e3d0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8066/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 participants
No description provided.