Security: Content Security Policy allows unsafe-eval

[tomaioo]

Summary

Security: Content Security Policy allows unsafe-eval

Problem

Severity: Critical | File: lib/Controller/DisplayController.php:L54

In lib/Controller/DisplayController.php, the ContentSecurityPolicy allows 'unsafe-eval' script domain. This severely weakens CSP protection and allows inline JavaScript execution, making the application vulnerable to XSS attacks.

Solution

Remove the line '$policy->addAllowedScriptDomain(''unsafe-eval'');' or replace with specific allowed script sources. If inline scripts are needed, use nonces instead.

Changes

• lib/Controller/DisplayController.php (modified)

[AndyScherzinger]

for ref: #265

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[miaulalala]

This change probably breaks the app — have you built and tested it locally? The mindmap editor is built on AngularJS 1.x (loaded via ng-app="mindmap" in templates/viewer.php), and AngularJS's default expression parser compiles bindings via new Function(...), which requires unsafe-eval in the CSP. I couldn't find an ng-csp attribute anywhere in the codebase, which is what you'd need to switch Angular to its CSP-safe interpreter before removing this. Without it, I'd expect this to silently break data bindings, ng-repeat, the export dropdown, etc. — likely showing up as CSP violations in the browser console rather than a PHP-level error, so it's easy to miss without actually opening devtools while testing the editor UI.