refactor(media): move image cache window management into NCImageCache - #4207
Merged
Conversation
Resume interrupted cycles from the stored offset and skip completed cycles only until the weekly interval expires. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Load avatars directly from disk while continuing background refreshes, and remove redundant preview cache preloading and cleanup. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Move cache window state, loading, and invalidation into NCImageCache and precompute cache items in the media data source. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Move media cache window state and loading into a dedicated actor to improve concurrency safety and remove main-actor restrictions. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the image cache window management out of
NCMediaand intoNCImageCache, making the cache responsible for its own lifecycle and state.Changes
centerIndex, cache task, missing images, extension tracking) intoNCImageCache.ImageCacheWindowItemto decouple cache management from media metadata.NCImageCache.NCMediaDataSourceinstead of recreating them on every scroll.NCMediaby delegating all cache window management toNCImageCache.MainActorsynchronization with an internal actor dedicated to cache window state, keeping cache management independent from the UI thread.Benefits
🤖 AI (if applicable)