Repository navigation
Replacing delly call with delly sr module (delly v1.3.3 -> v2.6.0) - #134
Merged
Merged
Conversation
Removes the sv_types fan-out and BCFTOOLS_CONCAT from the delly subworkflow, drops --svtype from ext.args, and regenerates the affected snapshots. Published output paths are unchanged.
nvnieuwk
reviewed
Sep 7, 2026
nvnieuwk
left a comment
Member
There was a problem hiding this comment.
One small comment, nice that the tool finally supports fully parallelization!. I'll approve once you've fixed the comment
ext.prefix = { "${meta.id}" } is not needed as it's the default
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
…nged` on same version of nf-core as .nf-core.yaml (nf-core:3.5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
delly/callmodule with the newdelly/srmodule (delly v1.3.3 → v2.6.0),and runs delly once per sample instead of once per SV type.
Why the SV type parallelization was removed
The delly flow previously ran delly 5× per sample (
--svtype DEL/INS/INV/DUP/BND) andstitched the results with
BCFTOOLS_CONCAT. Both halves of that stop making sense under v2:Delly v2 builds the VCF sample list from the variants it found
(
src/modvcf.h:431,jctCountMap.size()), where v1.3.3 built it from the input BAMs(
src/modvcf.h:394,c.files.size()). So an SV type that yields no calls produces a BCFwith no sample column, and
bcftools concatrefuses to combine it with the others:Different number of samples in test.DEL.bcf.--svtypenow defaults toALL, which delly accepts explicitly (src/util.h:378).Changes
modules/nf-core/delly/sr/installed,modules/nf-core/delly/call/removedsubworkflows/local/bam_variant_calling_delly/main.nf:DELLY_CALL→DELLY_SRwith thenew positional
suffixinput ("bcf");sv_typesfan-out,groupTuple(size:5)andBCFTOOLS_CONCATremovedconf/modules.config:--svtypedropped fromext.args;ext.prefixback to${meta.id};BCFTOOLS_CONCATblock removed.--map-qualand--min-clique-sizeare unchanged — bothstill exist in v2.6.0
CHANGELOG.md,docs/CITATIONS.mdupdatedPublished output paths are unchanged (
BCFTOOLS_SORTstill writes${meta.id}.delly),so no
tests/pipeline/*snapshot moved.Testing
All green on
--profile=+docker:tests/subworkflows/local/bam_variant_calling_delly— snapshot regeneratedtests/subworkflows/local/bam_sv_calling— snapshot regentests/default.nf.test— snapshot regenerated (merged VCFvariantsMD5moved, as expectedfor a caller version change)
tests/pipeline/sv,tests/pipeline/bedpe,tests/pipeline/all_types— pass againstexisting snapshots, unchanged
PR checklist
nf-core pipelines lint).CHANGELOG.mdis updated.