Repository navigation
fix(flex): mic source, DVK licence, remote_audio_tx id, TX state on reconnect, unkey on client drop - #15
Merged
Conversation
…econnect, unkey on client drop Radio behaviours AetherSDR's client-side voice keyer (#6292) depends on, found testing it against the sim: - `mic list` includes PC; `mic input <src>` selects the source, and the transmit status reports `mic_selection=` and `dax=` so a client reads them back. #6292 refuses to record unless the radio reports PC. - `sub license all` reports `digital_voice_keyer` enabled=1, or 0 with the new `--no-dvk-license`. AE fails open without it, so the unlicensed path was untestable. - `stream create type=remote_audio_tx` gets its own id; it shared netcw's. - `sub tx all` is answered with the current TX state. - A client that disconnects while keyed is unkeyed. tests/test_tx_audio_state.py pins all five (11 checks). PROTOCOL.md §10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five radio behaviours that AetherSDR's client-side voice keyer (aethersdr/AetherSDR#6292) relies on were missing from the sim. They turned up while testing that PR against flex-sim. Until now each one needed a throwaway patch before the test could run.
mic input <src>, nomic_selection=in the transmit status, no PC inmic listlicense featurestatusremote_audio_txsharednetcw's idsub tx allnot answered with TX stateChanges
mic listreturnsMIC,BAL,LINE,ACC,PC.mic input <src>selects the source. The transmit status now carriesmic_selection=anddax=.sub license allreportsdigital_voice_keyerwithenabled=1, orenabled=0with the new--no-dvk-license. This applies to rack mode too.remote_audio_txgets its own stream id (0x88000000+ radio).sub tx allis answered with the current interlock and transmit status.xmitor TUNE) is unkeyed.tests/test_tx_audio_state.py(11 checks, own ports :5995/:8735 and :5996/:8736) andPROTOCOL.md§10.Testing
tests/test_tx_audio_state.py: 11/11. It cannot start onmain, because--no-dvk-licensedoes not exist there.python -m pytest tests/: 43 passed, 0 skipped (Windows, Python 3.12).loopback_test.pypasses.--no-dvk-license, AE picks the Local keyer by itself🤖 Generated with Claude Code