Repository navigation
Docs review for SCF #46 reviewers - #295
Merged
Merged
Conversation
…ttlement and who paid Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…not 3134a51c) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Nov 2026) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The code stopped printing CIDs on 8 Nov 2026 (the Reporting export no longer returns them), but --help still said 'prints one CID per line, pipeable to nirium verify'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vault contract also accepts SwapExactIn/SwapExactOut; these methods only send Unwind and Invest. None takes a destination address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vault contract also accepts SwapExactIn/SwapExactOut; these methods only send Unwind and Invest. None takes a destination address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Eras256
marked this pull request as ready for review
November 12, 2026 07:45
M0nsxx
approved these changes
Nov 12, 2026
M0nsxx
left a comment
M0nsxx
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. README now links the real first mainnet settlement (8a2487b8), the agentic-payments skill no longer claims ongoing mainnet billing, the SDK READMEs list rebalance()'s four instructions, and the CLI help no longer promises CIDs in report export. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the nirium.xyz review in Eras256/nirium-core-private. It groups the public-repo fixes that come up while reviewing the site section by section.
README. "First real x402 payment" linked
3134a51c, which was the fifth settlement on 9 Jul. The first is8a2487b8(20:06:59 UTC).skills/nirium-agentic-payments/SKILL.md. This is the file skills.stellar.org serves, because
nirium-sdkredirects here. It said the mainnet endpoint "has been billing real USDC over x402 since 9 July 2026". The last settlement was on 29 Sep, and all 36 settlements came from our own test wallets (2 payers) and AgentLedger's integration tests (1 payer). The skill now cites the real first settlement and says who paid.packages/cli/bin/nirium.js. The sample CETES reference in the scaffold data goes from 5.57% to 5.55%, read from Etherfuse on 12 Nov 2026. It only ships with the next CLI release.
CLI
report exporthelp. The help still said"export anchors" prints one CID per line, pipeable to nirium verify, but the code stopped printing CIDs on 8 Nov 2026 (see CHANGELOG). It now says what it actually prints: the date and network of each anchor. The fix ships with the next CLI release.packages/sdk/README.md and packages/sdk-python/README.md. Both said
rebalance()"exposes exactly two instructions". DeFindex's contract also acceptsSwapExactInandSwapExactOut, while these SDK methods only sendUnwindandInvest, and none of the four takes a destination address. These READMEs ship to npm and PyPI, so the fix lands there with the next release of each package.Review complete. The README and skill changes take effect on merge (skills.stellar.org reads the skill from this repo). The SDK READMEs and the CLI change reach npm and PyPI with the next release of each package.
🤖 Generated with Claude Code