Simplify favicon - #211
Merged
Merged
Simplify favicon#211
Conversation
Inspired by this article: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs#step-1-prepare-the-svg This introduces a new favicon design in `public/icon.svg` as well as instructions for creating the derived favicon files. This also drops outdated manifests.
Deploying nmattia-com with
|
| Latest commit: |
786d061
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0138fb7d.nmattia-com.pages.dev |
| Branch Preview URL: | https://nm-favicon.nmattia-com.pages.dev |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The dark SVG glyph lacks sufficient contrast against dark browser chrome.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies favicon support and documents asset generation.
Changes:
- Adds a new SVG favicon and streamlined head links.
- Documents ICO and Apple touch icon generation.
- Removes obsolete manifest and platform-specific assets.
| File | Description |
|---|---|
src/components/Head.astro |
Simplifies favicon declarations. |
README.md |
Documents favicon generation. |
public/icon.svg |
Adds the new favicon design. |
public/manifest.json |
Removes the obsolete web manifest. |
public/browserconfig.xml |
Removes legacy Microsoft configuration. |
public/safari-pinned-tab.svg |
Removes the legacy Safari icon. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this article: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs#step-1-prepare-the-svg
This introduces a new favicon design in
public/icon.svgas well as instructions for creating the derived favicon files. This also drops outdated manifests.