Repository navigation
[feat] Add units to converter - #364
Conversation
New version checklist
|
Code Metrics Report
Code coverage of files in pull request scope (54.7%)
Reported by octocov |
| DERIVED_QUANTITIES,SSB_unfished,spawning_biomass_unfished,kg | ||
| DERIVED_QUANTITIES,Totbio_unfished,biomass_unfished,kg | ||
| DERIVED_QUANTITIES,SmryBio_unfished,biomass_unfished_midyear,kg | ||
| DERIVED_QUANTITIES,Recr_unfished,recruitment_unfished,kg |
There was a problem hiding this comment.
not sure this will be consistent -- we will need to figure this one out
|
@sbreitbart-NOAA I forgot to push these changes yesterday, but the sheet looks good to me now with the exception of the couple notes I made. Could you do the same for the BAM and Rceattle sheets then reping for review? |
|
@sbreitbart-NOAA looks like the chore for updating the example data worked! I haven't seen it commit like that before |
|
Just pinged. There were a lot of variables I was unsure about but did my best to guess. Yes- awesome that the GH action is working!! |
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
There was a problem hiding this comment.
LGTM! I made some updates to the other files. This is as much as I know and we can make fixes as we go and it gets used. Next up: adjusting our functions so units are automatically extracted 😄
Once the example data gets updated from the action, should be good to merge.
Great! Will merge 👍 (edit: manually triggered the action on the branch because it wasn't happening automatically) |
|
Note: will merge this after the GH action that generates the example_data is fixed (because this PR should include the updated example_data) |
2a2d6f0 to
f443bdc
Compare
… by 96b7b96 Update example data manually) [skip ci]
2 participants
Add units to the converter via the ss3_var_names.csv file