Repository navigation
[chore]: remove html_all_figs_tables() - #423
Merged
Merged
Conversation
…laced with the dashboard coming soon
Schiano-NOAA
requested review from
sbreitbart-NOAA
and
a balanced review from Copilot
October 16, 2026 15:17
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both deleted files contain only comments, with no unresolved review findings.
0 open findings
What changed in this PR
Removes the commented-out html_all_figs_tables() implementation and tests ahead of a planned dashboard replacement.
Changes:
- Deletes inactive HTML-generation code and documentation.
- Deletes disabled tests; runtime behavior and active test coverage are unchanged.
| File | Description |
|---|---|
| tests/testthat/test-html_all_figs_tables.R | Removes commented-out tests. |
| R/html_all_figs_tables.R | Removes commented-out implementation and documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sbreitbart-NOAA
approved these changes
Oct 16, 2026
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Please remove its mention in the workshop: https://nmfs-ost.github.io/workflows-workshop/Curriculum/Day_3/day_3.html#exporting
Contributor
Code Metrics Report
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
html_all_figs_tables