Repository navigation
Conversation
…ncorrect module" test issue
Test would fail with original module specification ("SPR_SERIES") because labels were present for the given module. Change to new module ("DERIVED_QUANTITIES") ensures test passes.
this alleviates users from having to interact with the tests to confirm MODULE choices
…d" tests with routine function call
…table files from tests
plot specific tests for rda generation were redundant with the save_all_plots test
save_all_plots and convert_output tests will run first, followed by the individual plotting and table function tests
Collaborator
Author
|
@sbreitbart-NOAA @Schiano-NOAA opened this so you can see the changes and test. Maybe a handful more things we want to add in here before merging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved efficiency of test suite:
Reduced total number of SS3 models tested with
convert_outputfrom 18 to 5. Chosen models were based on total model complexity and presence of specific modeling features (e.g., empirical biological parameters).Turned off interactivity for all plotting/table functions. This ensures that the test suite runs without user interaction. Closes [tests]: Set modules in all plot_* calls within test functions #416.
Removed redundant tests. rda generation was being tested for every plot and table function individually, as well as together with
save_all_plots. Removal of plot/table specific rda tests reduces total number of tests to run and makes for easier file I/O within the test environment (e.g., only have to remove tmp files once, rather than for every plot test). Closes [tests]: are "rda file made when indicated" tests needed for every plot? #418.Implemented parallel testing. All tests now run in parallel using the
testthatparallel framework. Theconvert_outputandsave_all_plotstests are given priority due to the time required to run, and are thus run before any of the plot/table specific tests. Total test suite runtime should be ~3 minutes.Closes #420