chore: remove unused C# and Java interop validators - #566
Open
cjbarth wants to merge 1 commit into
Open
Conversation
`test/validators/` held two hand-run cross-check harnesses: a Visual Studio 2010 C# project targeting .NET Framework 4.0 and a Maven project pinned to Java 1.7. Neither was run by CI, an npm script, or any documented workflow. Of the three C# sources one asserted nothing, one was entirely commented out, and one was not in the `<Compile>` group so it did not build. Committed build outputs (`bin/`, `obj/`, `.suo`) and a `.pfx` with its password in adjacent source came along with them. The interoperability value is already frozen into `test/static/`, which holds the reference outputs these harnesses produced. Record that provenance in a new `test/README.md` so it survives the deletion, and drop the now-dead `.gitignore` and `.prettierignore` entries. Closes node-saml#547 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (22)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 75.95% 76.48% +0.53%
==========================================
Files 9 9
Lines 1048 1059 +11
Branches 273 275 +2
==========================================
+ Hits 796 810 +14
+ Misses 144 142 -2
+ Partials 108 107 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547
test/validators/held two hand-run cross-check harnesses, neither run by CI, an npm script, or any documented workflow:Clientprofile, x86). Of its three sources,Program.cssigns or verifies and printssignature is validwhile asserting nothing,utilities.csis entirely commented out, andprogram-repro-misc-validation-and-canon.csis not in the<Compile>group so it does not build. Committed alongside:bin/Debug/*.exe,*.pdb,obj/, a binary.suo, andClientPrivate.pfxwith its password in adjacent source.maven-compiler-pluginsource/target 1.7, with log4j 1.2.17 and slf4j 1.7.12.Why removal rather than modernization
The interoperability value is already frozen into
test/static/. Verified while writing this:hmac_signature.xml,hmac.keyandhmac-foobar.keywere added in the same commit as the Java harness (c6f7aaa) and are exactly its output —test:Rootinurn:test, exclusive c14n, hmac-sha1, sha256 digest,some-key-name. The fixtures are the reference output; the harness was the one-time generator.A live harness only pays off if it runs in CI, and that means a
net8.0rewrite, adotnetjob, generated certs instead of a committed.pfx, and an actual diff against xml-crypto's output. For a stable surface that is a permanent second toolchain for a thin return.What lands instead
A new
test/README.mdrecords the provenance so it survives the deletion, names the harnesses, and says how to recover them (git show 0409418:test/validators). It also picks up the byte-sensitivity warning, which is easier to find there than inAGENTS.mdalone.Also drops the two now-dead ignore entries (
.gitignorefor the Maventarget/,.prettierignorefor the directory) and theAGENTS.mdreferences.Side effects
.sln.test/validators/XmlCryptoJavamoot — Bump commons-io:commons-io from 2.7 to 2.14.0 in /test/validators/XmlCryptoJava #552 can be closed.Verification
npm run build && npm test && npm run lintclean; 241 passing, unchanged frommaster.🤖 Generated with Claude Code