build: skip dockit on riscv64 - #62251
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62251 +/- ##
==========================================
- Coverage 90.07% 90.05% -0.02%
==========================================
Files 754 754
Lines 256395 256395
Branches 48494 48498 +4
==========================================
- Hits 230947 230897 -50
- Misses 16563 16615 +52
+ Partials 8885 8883 -2 🚀 New features to boost your workflow:
|
|
I think we can fix it (at least the |
|
|
Probably fixed with the updae in #62512 - running a test on my K1 at https://ci.nodejs.org/job/sxa-rvnodetest/399/ |
|
Noting that I hit this again today with a branch that had the doc-kit 1.4.1 added in https://github.com/nodejs/node/pull/64010/changes so this may still be required. Ref: https://ci.nodejs.org/job/sxa-node-test-commit-rvlinux/14/nodes=riscv64 |
|
Apparently the variable name in this PR didn't work for the check - changed from |
|
Noting that the request-ci triggers have been playing up. Ref: nodejs/build#4443 |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/76810/ (retry - no smartos) |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/76811/ (build - no smartos) |
8f929ed to
1cf3884
Compare
Signed-off-by: Stewart X Addison <sxa@ibm.com>
|
Force pushing to squash since no-one has reviewed yet and to rebase - no changes to what was in this PR earlier. |
|
Dropping to draft again while some further testing occurs to prevent anyone merging this for now but noting that we're still getthing this error, albeit ignored and so it doesn't prevent the build from continuing. |
The
doc-onlytarget gives a variety of failures on different riscv64 systems. These symptoms are described in nodejs/build#4099 (comment) in the sectionAdditional info on the Wasm doc-only crashThis removes the doc-only target from being run by default as part of
make test-cisimilar to what has been done for AIX and IBMi.