src: fix live lock between environments with blocked requests - #65520
Merged
nodejs-github-bot merged 1 commit intoSep 2, 2026
Merged
Conversation
IlyasShabi
force-pushed
the
ishabi/web-locks-livelock-62644
branch
from
August 24, 2026 17:43
d979993 to
769b088
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65520 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01%
==========================================
Files 754 754
Lines 256395 256397 +2
Branches 48494 48501 +7
==========================================
- Hits 230947 230946 -1
- Misses 16563 16572 +9
+ Partials 8885 8879 -6
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 25, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/web-locks-livelock-62644
branch
from
September 1, 2026 13:23
769b088 to
358368a
Compare
Collaborator
Collaborator
|
Landed in 0375d09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LockManager::ProcessQueue()woke every other env with any pending request, even when none of those requests could make progress. Two envs with requests blocked on the same resource would wake each other back and forth forever.This PR will wake another env only when one of its requests can make progress:
Fixes #62644