src: fix startup snapshot reproducibility of InternalFieldInfo - #65684
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65684 +/- ##
==========================================
- Coverage 90.07% 90.06% -0.01%
==========================================
Files 754 754
Lines 256395 256395
Branches 48494 48495 +1
==========================================
- Hits 230947 230926 -21
- Misses 16563 16586 +23
+ Partials 8885 8883 -2
🚀 New features to boost your workflow:
|
joyeecheung
approved these changes
Sep 1, 2026
joyeecheung
added
request-ci
Member
|
It's not clear how but there is a fs test failing across Linux. Maybe it needs a rebase? |
`memset` before a placement `new` can be optimized away by GCC due to lifetime analysis. This causes the buffer in the startup snapshot vulnerable to ASLR. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
snapshot-repro
branch
from
September 1, 2026 13:17
66783ae to
4be2193
Compare
Member
Author
|
Right, I don't think the CI failures on fs were related. Rebased. |
Collaborator
legendecas
added
author ready
richardlau
approved these changes
Sep 2, 2026
legendecas
added
the
commit-queue
Collaborator
|
Landed in c988b7d |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memsetbefore a placementnewcan be optimized away by GCC due tolifetime analysis. This causes the buffer in the startup snapshot
vulnerable to ASLR.
Fixes: #65508