Skip to content

crypto: ensure HKDF and PBKDF2 limits are validated - #65704

Open
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-chekc-limits
Open

crypto: ensure HKDF and PBKDF2 limits are validated#65704
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-chekc-limits

Conversation

@panva

@panva panva commented Sep 1, 2026

Copy link
Copy Markdown
Member

Followup to #62226 and #65222

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Reject iteration counts outside of OpenSSL supported range

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from RafaelGSS September 1, 2026 12:40
@panva panva added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Sep 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (f9ab994) to head (e51bc56).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65704      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         754      754              
  Lines      256395   256408      +13     
  Branches    48494    48501       +7     
==========================================
+ Hits       230947   230949       +2     
- Misses      16563    16574      +11     
  Partials     8885     8885              
Files with missing lines Coverage Δ
lib/internal/crypto/hkdf.js 100.00% <100.00%> (ø)
lib/internal/crypto/webidl.js 97.18% <100.00%> (+0.01%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 1, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants