[v22.x backport] test: account for varied OpenSSL CCM final behaviours - #65711
Open
everett1992 wants to merge 1 commit into
Open
[v22.x backport] test: account for varied OpenSSL CCM final behaviours#65711everett1992 wants to merge 1 commit into
everett1992 wants to merge 1 commit into
Conversation
everett1992
force-pushed
the
backport-65542-to-v22.x
branch
from
September 1, 2026 16:36
c3fbbe0 to
25fc16c
Compare
everett1992
pushed a commit
to everett1992/node
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> (cherry picked from commit 28b571c) Refs: openssl/openssl#32427 Refs: nodejs#65710 Refs: nodejs#65711
everett1992
pushed a commit
to everett1992/node
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> (cherry picked from commit 28b571c) Refs: openssl/openssl#32427 Refs: nodejs#65711 Refs: nodejs#65710
Backport of the test-only commit from nodejs#65542. Distributions that build Node against their own newer OpenSSL and run the upstream test suite already see this test fail on v22.x and v24.x. The same backport is needed if and when these lines update the bundled OpenSSL. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Signed-off-by: Caleb ツ Everett <calebev@amazon.com> PR-URL: nodejs#65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> (cherry picked from commit 28b571c) Refs: openssl/openssl#32427 Refs: nodejs#65710 Refs: nodejs#65711 Assisted-by: a closed-source coding agent
everett1992
force-pushed
the
backport-65542-to-v22.x
branch
from
September 1, 2026 17:00
25fc16c to
557875b
Compare
everett1992
pushed a commit
to everett1992/node
that referenced
this pull request
Sep 1, 2026
Backport of the test-only commit from nodejs#65542. Distributions that build Node against their own newer OpenSSL and run the upstream test suite already see this test fail on v22.x and v24.x. The same backport is needed if and when these lines update the bundled OpenSSL. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Signed-off-by: Caleb ツ Everett <calebev@amazon.com> PR-URL: nodejs#65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> (cherry picked from commit 28b571c) Refs: openssl/openssl#32427 Refs: nodejs#65710 Refs: nodejs#65711 Assisted-by: a closed-source coding agent
trivikr
approved these changes
Sep 1, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of
test: account for varied OpenSSL CCM final behaviours(28b571c) from #65542, which landed via
commit-queue-rebase, so thetest fix is one commit inside the OpenSSL 3.5.8 update rather than its own
PR.
It does not cherry-pick cleanly:
mainhashasOpenSSL(3)where thisbranch still has
hasOpenSSL3, and the block is not wrapped in anif (!ciphers.includes('aes-128-ccm'))guard on this branch(indentation only).
Why now
We build our Node distribution against our own OpenSSL rather than the
bundled copy, and we run the upstream test suite. We have just updated to
OpenSSL 3.0.22 (for v20.x/v22.x) and 3.5.8 (for v24.x/v26.x), so
parallel/test-crypto-authenticatedis already failing on our v22.x andv24.x builds. The same backport will be needed here if and when these
branches update the bundled OpenSSL.
OpenSSL 3.0.22 and 3.5.8 include openssl/openssl#32427. Before it,
ossl_ccm_stream_final()returned early when the payloadupdate()wasskipped, so encryption produced no tag and decryption could report
success without verifying the supplied tag. With the fix,
final()on anempty CCM message succeeds and produces a real tag instead of failing
with
ERR_OSSL_TAG_NOT_SET— which is what the test assertedunconditionally.
Verification
Ran
parallel/test-crypto-authenticatedbefore and after this change onNode 22.23.2 built against shared OpenSSL 3.0.22: fails before, passes
after. Also confirmed on 20.20.2 (OpenSSL 3.0.22) and 26.7.0 (OpenSSL
3.5.8).
AI disclosure
The conflict resolution and this description were drafted with an
agentic coding CLI. I ran the test before and after on the builds above
and read the OpenSSL change to confirm the behaviour it describes.
Companion backport for v24.x: #65710