quic: add promise to QuicStream for pending strms by martenrichter · Pull Request #65862 · nodejs/node

martenrichter · 2026-09-06T17:46:45Z

before this PR, it was necessary to poll, if a
stream can not be created immediately due to
flow control.
This PR adds a promise to QuicStream, that fulfills, when a stream is available and ready.

nodejs-github-bot · 2026-09-06T17:46:50Z

Review requested:

@nodejs/quic

martenrichter · 2026-09-06T17:47:36Z

@jasnell @pimterry that is the separate PR for a promise for pending streams

nodejs-github-bot · 2026-09-06T18:42:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77102/

codecov · 2026-09-06T19:43:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (1dd48de) to head (4db975e).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65862      +/-   ##
==========================================
- Coverage   90.18%   90.16%   -0.03%     
==========================================
  Files         771      771              
  Lines      265451   265520      +69     
  Branches    50452    50466      +14     
==========================================
+ Hits       239398   239400       +2     
- Misses      16985    17058      +73     
+ Partials     9068     9062       -6

Files with missing lines	Coverage Δ
lib/internal/quic/quic.js	`100.00% <100.00%> (ø)`
lib/internal/quic/symbols.js	`100.00% <100.00%> (ø)`

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pimterry · 2026-09-07T15:40:37Z

 added: v23.8.0
 -->

+### `stream.ready`


Imo stream.opened would be a slightly clearer API, to match session.opened and stream.stats.opened_at.

Ok, I have changed it. (Will push soon). readycame from WebStream semantics.

pimterry

Thanks for the fixes @martenrichter. Code changes all look good to me.

In the docs though the name of the field is wrong, and there's now a conflict here so this'll need a rebase. Otherwise LGTM.

pimterry · 2026-09-08T18:07:01Z

 -->

-### `stream.ready`
+### `stream.open`


Docs say open, but the actual field is opened.

Oh yes, fixed.

jasnell · 2026-09-08T19:27:49Z

@martenrichter ... this will need to be rebased

before this PR, it was necessary to poll, if a stream can not be created immediately due to flow control. This PR adds a promise to QuicStream, that fulfills, when a stream is available and ready. Signed-off-by: Marten Richter <marten.richter@freenet.de>

martenrichter · 2026-09-09T06:25:41Z

Is rebased, but I am not sure with one change, please look at my comment.

jasnell · 2026-09-10T14:07:40Z

CI is likely to fail due to a current unrelated issue on Windows. Hopefully that will be resolved shortly.

nodejs-github-bot · 2026-09-10T16:37:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77310/

nodejs-github-bot · 2026-09-12T08:29:38Z

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash PRs the Commit Queue should land as one squashed commit. to land it as one commit, or commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

- Loading data for nodejs/node/pull/65862
✔  Done loading data for nodejs/node/pull/65862
----------------------------------- PR info ------------------------------------
Title      quic: add promise to QuicStream for pending strms (#65862)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     martenrichter:addreadytoquicstream -> nodejs:main
Labels     c++, lib / src, author ready, needs-ci, quic, commit-queue
Commits    7
 - quic: add promise to QuicStream for pending strms
 - quic: fix lint
 - quic: use opened instead ready for QuicStream
 - quic: fix rejection of opened promise and add test
 - quic: fix lint and test
 - quic: fix doc opened instead of open
 - quic: move EmitStreamAvailable
Committers 1
 - Marten Richter <marten.richter@tu-berlin.de>
PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Sep 2026 17:46:45 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65862#pullrequestreview-5126181969
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/65862#pullrequestreview-5163047814
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-09-10T16:37:10Z: https://ci.nodejs.org/job/node-test-pull-request/77310/
- Querying data for job/node-test-pull-request/77310/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   89b32cf16d..dff7a160fe  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 546a29107e lib: put node:bench behind an --experimental-bench flag
 - dff7a160fe lib: put node:bench behind an --experimental-bench flag
--------------------------------------------------------------------------------
HEAD is now at dff7a160fe lib: put node:bench behind an --experimental-bench flag
   ✔  Reset to origin/main
- Downloading patch for 65862
From https://github.com/nodejs/node
 * branch                  refs/pull/65862/merge -> FETCH_HEAD
✔  Fetched commits as c8b346e98e83..4db975e6c962
--------------------------------------------------------------------------------
[main 0e67097cf8] quic: add promise to QuicStream for pending strms
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Sun Sep 6 19:19:35 2026 +0200
 10 files changed, 92 insertions(+), 1 deletion(-)
[main 9442821931] quic: fix lint
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Sun Sep 6 19:57:55 2026 +0200
 2 files changed, 4 insertions(+)
[main ca51f85e6b] quic: use opened instead ready for QuicStream
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 07:54:12 2026 +0200
 4 files changed, 16 insertions(+), 16 deletions(-)
[main 131fdbcd71] quic: fix rejection of opened promise and add test
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 08:07:27 2026 +0200
 2 files changed, 15 insertions(+), 2 deletions(-)
[main 4019c67f4a] quic: fix lint and test
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 08:21:07 2026 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
[main e7d53bf13c] quic: fix doc opened instead of open
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Wed Sep 9 07:59:11 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 629e87079a] quic: move EmitStreamAvailable
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Thu Sep 10 06:57:30 2026 +0200
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 7 commits in the PR. Attempting autorebase.
(node:894) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: add promise to QuicStream for pending strms

before this PR, it was necessary to poll, if a
stream can not be created immediately due to
flow control.
This PR adds a promise to QuicStream, that fulfills,
when a stream is available and ready.

Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD bea11cd2c0] quic: add promise to QuicStream for pending strms
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Sun Sep 6 19:19:35 2026 +0200
 10 files changed, 92 insertions(+), 1 deletion(-)
Rebasing (3/14)
Rebasing (4/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: fix lint

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 200421b674] quic: fix lint
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Sun Sep 6 19:57:55 2026 +0200
 2 files changed, 4 insertions(+)
Rebasing (5/14)
Rebasing (6/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: use opened instead ready for QuicStream

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 89a734f820] quic: use opened instead ready for QuicStream
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 07:54:12 2026 +0200
 4 files changed, 16 insertions(+), 16 deletions(-)
Rebasing (7/14)
Rebasing (8/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: fix rejection of opened promise and add test

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 883913e631] quic: fix rejection of opened promise and add test
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 08:07:27 2026 +0200
 2 files changed, 15 insertions(+), 2 deletions(-)
Rebasing (9/14)
Rebasing (10/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: fix lint and test

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD e15641f181] quic: fix lint and test
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Tue Sep 8 08:21:07 2026 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (11/14)
Rebasing (12/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: fix doc opened instead of open

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 7b0f9dab1b] quic: fix doc opened instead of open
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Wed Sep 9 07:59:11 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (13/14)
Rebasing (14/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
quic: move EmitStreamAvailable

PR-URL: https://github.com/nodejs/node/pull/65862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD cc27e61997] quic: move EmitStreamAvailable
 Author: Marten Richter <marten.richter@tu-berlin.de>
 Date: Thu Sep 10 06:57:30 2026 +0200
 1 file changed, 3 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

nodejs-github-bot · 2026-09-12T09:03:05Z

Landed in 312c562

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 6, 2026

martenrichter mentioned this pull request Sep 6, 2026

quic: add option waitUntilAvailable to creating streams #65331

Open

jasnell approved these changes Sep 6, 2026

View reviewed changes

bjohansebas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2026

bjohansebas approved these changes Sep 6, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2026

pimterry reviewed Sep 7, 2026

View reviewed changes

trivikr added the quic Issues and PRs related to the QUIC transport implementation. label Sep 7, 2026

jasnell requested a review from pimterry September 8, 2026 17:49

pimterry reviewed Sep 8, 2026

View reviewed changes

martenrichter added 6 commits September 9, 2026 08:20

quic: fix lint

5f205d5

quic: use opened instead ready for QuicStream

a21a26e

quic: fix rejection of opened promise and add test

dc01a8d

quic: fix lint and test

5570ac6

quic: fix doc opened instead of open

ddfdc5d

martenrichter force-pushed the addreadytoquicstream branch from a31c748 to ddfdc5d Compare September 9, 2026 06:22

martenrichter commented Sep 9, 2026

View reviewed changes

Comment thread src/quic/streams.cc Outdated

quic: move EmitStreamAvailable

4db975e

pimterry approved these changes Sep 10, 2026

View reviewed changes

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026

jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 10, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026

panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 12, 2026

panva added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 12, 2026

nodejs-github-bot merged commit 312c562 into nodejs:main Sep 12, 2026
89 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026

Uh oh!

Uh oh!

Conversation

martenrichter commented Sep 6, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Uh oh!

martenrichter commented Sep 6, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Uh oh!

codecov Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pimterry Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

martenrichter Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pimterry left a comment

Choose a reason for hiding this comment

Uh oh!

pimterry Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

martenrichter Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

jasnell commented Sep 8, 2026

Uh oh!

Uh oh!

martenrichter commented Sep 9, 2026

Uh oh!

jasnell commented Sep 10, 2026

Uh oh!

nodejs-github-bot commented Sep 10, 2026

Uh oh!

nodejs-github-bot commented Sep 12, 2026

Commit Queue failed

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Sep 6, 2026 •

edited

Loading