Skip to content

lib: set exit code on failed node:bench run() - #66534

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:set-exit-code-on-failed-node-bench-run
Open

lib: set exit code on failed node:bench run()#66534
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:set-exit-code-on-failed-node-bench-run

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I noticed the run() was exiting with exitCode 0 even when the benchmark fn fails

@RafaelGSS
lib: set exit code on failed node:bench run()
6401472 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS requested a review from jasnell October 5, 2026 14:38
@RafaelGSS
RafaelGSS marked this pull request as ready for review October 5, 2026 14:38
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 5, 2026
@codecov

codecov Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (773bdd1) to head (6401472).
⚠️ Report is 89 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66534      +/-   ##
==========================================
- Coverage   90.42%   90.39%   -0.03%     
==========================================
  Files         790      791       +1     
  Lines      275421   275995     +574     
  Branches    52830    52973     +143     
==========================================
+ Hits       249052   249494     +442     
- Misses      16776    16912     +136     
+ Partials     9593     9589       -4
Files with missing lines Coverage Δ
lib/internal/bench_runner/harness.js 98.95% <100.00%> (+<0.01%) ⬆️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78190/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78198/

@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 6, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 7, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ✖    - build-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315131/job/111817860360)
   ✖    - format-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861124)
   ✖    - lint-codeowners: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861267)
   ✖    - lint-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861293)
   ✖    - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861446)
   ✖    - lint-py: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861529)
   ✖    - lint-addon-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817862223)
   ✖    - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315222/job/111817860941)
   ✖    - Build slim tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315519/job/111817862658)
   ✖    - aarch64-linux: Cache V8 build: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315519/job/111818423573)

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66534
�[36m⠋�[39m Loading data for nodejs/node/pull/66534
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66534
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66534
�[36m⠋�[39m Getting comments from nodejs/node/pull/66534
�[36m⠋�[39m Getting commits from nodejs/node/pull/66534
✔  Done loading data for nodejs/node/pull/66534
----------------------------------- PR info ------------------------------------
Title      lib: set exit code on failed node:bench run() (#66534)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:set-exit-code-on-failed-node-bench-run -> nodejs:main
Labels     author ready, needs-ci, commit-queue
Commits    1
 - lib: set exit code on failed node:bench run()
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/66534
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66534
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 Oct 2026 14:37:21 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/66534#pullrequestreview-5416297845
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/66534#pullrequestreview-5416451799
   ✔  - Bryan English (@bengl): https://github.com/nodejs/node/pull/66534#pullrequestreview-5430407116
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/66534#pullrequestreview-5433933914
   ✖  16 GitHub CI job(s) cancelled:
   ✖    - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/37326315021/job/111817859658)
   ✖    - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/37326315021/job/111817860111)
   ✖    - build-tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315019/job/111817869002)
   ✖    - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315019/job/111818594479)
   ✖    - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315065/job/111817859744)
   ✖    - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315120/job/111817860357)
   ✖    - build-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315131/job/111817860360)
   ✖    - format-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861124)
   ✖    - lint-codeowners: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861267)
   ✖    - lint-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861293)
   ✖    - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861446)
   ✖    - lint-py: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817861529)
   ✖    - lint-addon-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315149/job/111817862223)
   ✖    - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315222/job/111817860941)
   ✖    - Build slim tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315519/job/111817862658)
   ✖    - aarch64-linux: Cache V8 build: CANCELLED (https://github.com/nodejs/node/actions/runs/37326315519/job/111818423573)
   ℹ  Last Full PR CI on 2026-10-06T05:39:56Z: https://ci.nodejs.org/job/node-test-pull-request/78198/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78198/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78198/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78198/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
�[36m⠹�[39m Querying API for job/node-test-pull-request/78198/
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bengl bengl bengl approved these changes
@jasnell jasnell jasnell approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RafaelGSS @nodejs-github-bot @bengl @jasnell @UlisesGascon @atlowChemi