Skip to content

lib: default node:bench warmup to 10 invocations - #66536

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:default-node-bench-warmup-to-10-invocations
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:default-node-bench-warmup-to-10-invocations

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

By default, I expect node:bench to have its proper warm-up.

What do you think? @jasnell

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS requested a review from jasnell October 5, 2026 14:52
@RafaelGSS
RafaelGSS marked this pull request as ready for review October 5, 2026 14:52
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 5, 2026
@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (bbd566d) to head (c3d2725).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66536      +/-   ##
==========================================
- Coverage   92.74%   90.39%   -2.36%     
==========================================
  Files         422      791     +369     
  Lines      193170   275991   +82821     
  Branches    29783    52982   +23199     
==========================================
+ Hits       179160   249487   +70327     
- Misses      13682    16905    +3223     
- Partials      328     9599    +9271     
Files with missing lines Coverage Δ
lib/internal/bench_runner/benchmark.js 99.65% <100.00%> (ø)

... and 499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@atlowChemi atlowChemi added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants