Skip to content

vfs: add callback readv and writev handlers - #66548

Open
dcavalcante wants to merge 1 commit into
nodejs:mainfrom
dcavalcante:vfs-readv-writev
Open

dcavalcante wants to merge 1 commit into
nodejs:mainfrom
dcavalcante:vfs-readv-writev

Conversation

@dcavalcante

Copy link
Copy Markdown

A mounted VFS causes callback readv and writev to call missing handlers, breaking both virtual and real file descriptors.

This adds both handlers and preserves I/O for real descriptors..

Fixes: #66532

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

A mounted VFS causes callback readv and writev to call missing
handlers, breaking both virtual and real file descriptors.

Add both handlers while preserving I/O for real descriptors.

Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (9746ebc) to head (7710c7a).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66548   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         791      791           
  Lines      276120   276132   +12     
  Branches    53022    53039   +17     
=======================================
+ Hits       249618   249645   +27     
+ Misses      16897    16894    -3     
+ Partials     9605     9593   -12     
Files with missing lines Coverage Δ
lib/internal/vfs/setup.js 87.26% <100.00%> (+0.13%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: createVfsHandlers() does not implement writev(fd, buffers, position)

2 participants