Conversation
The configuration value build.crossCompile.enabled is always assumed to be true, and the image to enable it is always run regardless. This change will skip this step if enabled is set to false. Since the default value is true, the default behavior remains the same. This is a fix for issue nokia#16. Signed-off-by: Michael Grymporounis <michail.grymporounis@nokia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 37.73% 37.73%
=======================================
Files 23 23
Lines 1569 1569
=======================================
Hits 592 592
Misses 917 917
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
I don't think it is the best approach to add the check inside the function enableCrossCompilation. We should do it one level above. Check #44 |
Collaborator
|
I merged #44 so closing this as deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration value build.crossCompile.enabled is always assumed to be true, and the image to enable it is always run regardless. This change will skip this step if enabled is set to false. Since the default value is true, the default behavior remains the same.
This is a fix for issue #16.