Repository navigation
chore: separate PR structure and code validation - #377
Merged
Merged
Conversation
drake-nominal
force-pushed
the
codex/ci-names
branch
2 times, most recently
from
September 22, 2026 23:47
b2bc3a6 to
962d5d9
Compare
drake-nominal
force-pushed
the
codex/ci-names
branch
from
September 22, 2026 23:56
962d5d9 to
4ecf87c
Compare
drake-nominal
force-pushed
the
codex/ci-names
branch
from
September 23, 2026 00:02
4ecf87c to
c7f3ffb
Compare
drake-nominal
force-pushed
the
codex/ci-names
branch
2 times, most recently
from
September 23, 2026 00:07
912a25e to
0562a29
Compare
drake-nominal
force-pushed
the
codex/ci-names
branch
from
September 23, 2026 00:11
0562a29 to
69878ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate Rust and Python checks into
.github/workflows/validate.yml(Code validation). Keep PR metadata checks in.github/workflows/pr.yml(PR structure), so title and description edits do not rerun builds or wheel tests. Use explicit, unique job IDs as required-check contexts; GitHub supplies the workflow prefix in its UI.Require these exact GitHub Actions check names:
Remove superseded contexts from the main ruleset, including entries containing workflow prefixes. The ruleset is not changed here. Semgrep's externally managed
semgrep-cloud-platform/scanis unchanged.Give Python formatting a separate lightweight Depot job. Its shared Just check and fix recipes use
uv run --only-group dev --lockedso it runs the locked Ruff version without building workspace bindings. Keep Python lint and typing together, Rust build and tests together, and the existing wheel-test matrix. All validation jobs run independently.Run code validation on pushes to main and on PR open, reopen, and synchronize events across all target branches. Run PR structure on PR open, reopen, synchronize, and edit events. Python validation now also covers PRs targeting branches other than main.
Keep publishing separate in
crates.ymlandwheels.yml, preserving their distinct triggers and permissions. Keep Dependabot approval indeps.yml; remove the unused metadata-fetch action and scope its token to content read and PR write. The approval filter and command remain unchanged. Document CI/CD structure, naming, and required-check matching in.github/workflows/README.md, and label steps by their actual validation and tool. Update external links or workflow dispatch callers for renamed files.Use a direct
uv lock --checkstep instead of a shell error wrapper that reruns the command through backtick expansion. Use the same pinned Just action throughout code validation.Independent of #367 and #368; revisit those after this cutover.
Validation: actionlint passes with custom Depot labels allowed. Parsed YAML checks confirm existing validation job commands and wheel matrices are preserved except for moving Python formatting to its own job. All 11 job IDs and 27 expanded check names are unique. Event coverage is verified: PR edits run metadata validation only, while code updates run both workflows. Both formatting check and fix pass for 12 files using a development-tools-only environment. The lockfile check passes. Parsed comparisons confirm publishing behavior and the Dependabot approval filter/command are unchanged; Dependabot approval and publishing were not exercised live. Pinned rustfmt, 51 unit tests, and 3 doctests pass locally. Publishing workflows were not dispatched; CI reruns after this update.