Repository navigation
fix: include py-nominal-streaming changes in the changelog - #446
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog is generated from the
nominal-streamingcrate only, so commits that touch justpy-nominal-streaming/never appear. For example, #443 is missing from the 0.10.7 entry.Add
changelog_include = ["py-nominal-streaming"]to thenominal-streamingpackage so those commits are listed in the shared changelog. Past entries are not backfilled.This line was previously added in #72 and removed in #67 and #76 during the initial release setup, without a recorded reason, so the next release PR is worth a look to confirm it reads correctly.
Testing
Ran
release-plz updatelocally (release-plz 0.4.2) with a throwaway Python-only commit on top of this change. The generated 0.10.8 entry listed both #425 and the Python-only commit. The probe commit and generated files were discarded.