[ogulcanaydogan]

Fixes #1378.

notation plugin install --url used the URL from the user in its messages as it is, so a URL with user info showed the password in the parse error, in the Downloading plugin from line, in the download error and in the bad status and size limit errors of DownloadPluginFromURL.

This uses (*url.URL).Redacted() for the messages (https://user:xxxxx@host/...). The parse error no longer contains the URL, because the error of url.Parse embeds it. That error is now failed to parse plugin download URL with error: invalid URL escape "%", so the existing unit test for it is updated. The e2e test that matches failed to download plugin from URL https://localhost.test is not affected, since that URL has no credentials.

Tests:

• TestInstall: a parse error and a refused connection with credentials in the URL
• TestDownloadPluginFromURL_BadStatusRedactsCredentials: a 404 from a local test server

They fail without the change.

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.19%. Comparing base (9ba75db) to head (35749e7).

Files with missing lines	Patch %	Lines
cmd/notation/internal/plugin/plugin.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   80.10%   80.19%   +0.09%     
==========================================
  Files          68       68              
  Lines        3076     3080       +4     
==========================================
+ Hits         2464     2470       +6     
+ Misses        403      402       -1     
+ Partials      209      208       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.